Conversation
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
- Changed from sdk.AddTool (validates schema) to server.AddTool (no validation) - This allows including InputSchema from backends using different JSON Schema versions - Updated NormalizeInputSchema to provide default empty object schema when backend provides none - Updated test to verify nil schemas get normalized to empty object schema - All tests pass This fixes the issue where clients were wrapping parameters in "data" field because they didn't understand the tool parameter structure. Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
- Apply same fix to routed mode for consistency - Add safe type assertion in test to prevent potential panic - Format code Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
- Add nil check before type assertion in test - Clarify comment about handler parameter usage - Format code Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Verify correct exposure of safeoutputs tools to clients
Fix: Include inputSchema in tools/list responses to prevent client parameter wrapping
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clients were wrapping tool parameters in a "data" field (e.g.,
{"arguments":{"data":{"body":"...)) because the gateway was omittinginputSchema` from tools/list responses. Without schema information, clients couldn't understand parameter structure.Root Cause
The gateway intentionally omitted
inputSchemawhen registering tools to avoid JSON Schema version conflicts (draft-07 from backends vs draft-2020-12 required by SDK validation). This left clients unable to parse tool parameter requirements.Changes
Switch to non-validating tool registration:
server.AddTool(method, no validation) instead ofsdk.AddTool(function, validates)inputSchemafrom backends regardless of JSON Schema versionHandle missing schemas:
NormalizeInputSchemanow provides default empty object schema when backend returns nilExample
Before (tools/list response):
{ "tools": [{ "name": "create_output", "description": "Create an output" // inputSchema missing - client guesses wrong }] }After:
{ "tools": [{ "name": "create_output", "description": "Create an output", "inputSchema": { "type": "object", "properties": { "body": {"type": "string"} } } }] }💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.